WooCommerce admin products filter by on sale

WooCommerce admin products filter by on sale

I needed the ability to filter the WooCommerce products list within admin by products which where on sale. This was to allow the client to easily find products they have put on offer within certain categories. The below code achieves this.

It does need some work, as it currently ignores the on sale start and end dates, however you should be able to easily modify it for this purpose.


This code is provided as it and may require changes to work for your needs.

Leave a Reply

This site uses Akismet to reduce spam. Learn how your comment data is processed.


  1. Jarkko Saltiola

    Thank’s for this, helped a bit.

    There’s a little typo though. Line 32 gives “PHP Parse error: syntax error, unexpected ‘='”.

    So just change “= >” to “=>”.

  2. Great.

    It Worked, perfectly

    I was able to sort the products based on onsale products, giving me the opportunity to bulk edit only onsale products

    Thank you

  3. Hi,

    Thanks a lot !
    It works !
    You safe my time !
    Love you !

    • I need some help here.

      How to filter by Attribute?

      Would you help me, please..

      • I dont have any code examples to hand, but I do have another filter code example I have just posted. Maybe one of these may get you pointed in the right direction?

        I think you should be able to use the filter by image example, and change the attribute values / search paramamters. As the filter by image example is based around product attributes / meta data values.


        Hope that helps get your in the right direction!

  4. Pingback: WooCommerce admin products filter by image | Shane Rutter Blog

  5. oppo

    1) fix
    $selected = filter_input(INPUT_GET, ‘product_sale’, FILTER_VALIDATE_INT);
    if ($selected == false) {
    $selected = 0;
    $output .= ‘

    Filter by sale
    On sale
    Not on sale


    2) fix
    $selected = filter_input(INPUT_GET, ‘product_sale’, FILTER_VALIDATE_INT);
    if (!is_admin() || (isset($_GET[‘product’]) && $_GET[‘post_type’] != “product”) || !$selected ) {
    return $where;

      • pacmanito

        You forgot to add (isset($_GET[‘product’]) condition to your code, otherwise PHP warning is thrown. Another way is to use get_query_var(‘post_type’) instead of $_GET[‘product’]

  6. Arek


    Fix for variations:

    1) SELECT p.ID to: SELECT p.ID, p.post_parent (2 places)
    2) return $n->ID; to return $n->post_parent > 0 ? $n->post_parent : $n->ID; (2 places)

  7. Radim

    Many thanks for this, it helped a lot.
    A little fix:
    $output .= ‘

    Filter by sale
    On sale
    Not on sale


  8. Radim

    A little fix:
    option value=”1″ ‘ . (($selected === 1) ? ‘selected=”selected”‘ : ”) . ‘
    option value=”2″ ‘ . (($selected === 2) ? ‘selected=”selected”‘ : ”) . ‘

  9. pacmanito

    It’s rather strange – when I check the $querystr query for “not on sale” directly via DB the result does not contain sale items. But when the snippet is run in WP it returns sale products and checking via Query Monitor I can see that the part of query added via snippet (AND wp.ID NOT IN (***)) contains IDs of sale product. I can’t get how it happens. And it’s only for published products, everything works as expected for draft products.
    At the same time, I was able to get proper results via changing $querystr query for “not on sale” products to the same as for “on sale” (without NOT) and moving $where part inside if clause and swapping wp.ID IN for wp.ID NOT IN for “not on sale” products.

    • Is it possible another plugin is adding to the query causing the results to change? I did have an issue with another plugin tampering with query results at one point.